Migrate to go-jose/v4 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siretart
force-pushed
the
siretart/jose-v4
branch
from
592a8b3 to
a70e171
Compare
stefanberger
approved these changes
Jun 4, 2024
|
Can you please rebase on latest main branch so we can get rid of the test error. |
|
@siretart Still there? Can you rebase on latest master so that the CI/CD tests are passing? |
siretart
force-pushed
the
siretart/jose-v4
branch
from
a70e171 to
1283753
Compare
The main change in go-jose/v4 is the requirement to specify accepted "alg" and "enc" parameters. This is to enhance security, like for instance "the billion hashes attach" presented at BlackHat 2023. Note that go-jose/v4 requires go 1.21 References: go-jose/go-jose#64 (comment) Signed-off-by: Reinhard Tartler <[email protected]>
siretart
force-pushed
the
siretart/jose-v4
branch
from
1283753 to
913ce88
Compare
|
@stefanberger thanks for the ping, I've just force-pushed that rebase. |
|
Thanks. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in go-jose/v4 is the requirement to specify accepted
"alg" and "enc" parameters. This is to enhance security, like for
instance "the billion hashes attach" presented at BlackHat 2023.
Note that go-jose/v4 requires go 1.21
References: go-jose/go-jose#64 (comment)
Signed-off-by: Reinhard Tartler [email protected]