memtierd: allow overriding go version for image build. #456
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align with the rest of the plugins, allowing GO_VERSION to override the golang version used to build the image. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/memtierd/dockerfile-go-version
branch
from
b7531c6 to
66ca0b9
Compare
fmuyassarov
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align with the rest of the plugins, allowing GO_VERSION to override the golang version used to build the image. This should prevent
nri-memtierdimage build failures after a go patch-level version bump ingo.mod, when the image has been recently built with the same minor go version, but with a smaller patch level.