Add balloon type specific pinMemory option #451
Conversation
There was a problem hiding this comment.
Looks fine, apart from a formatting error which needs fixing. Also, I think we should try to keep libmem in the loop about total memory usage. The container either might have some pinning already calculated by some other component or it will be pinned to all memory nodes. In either case, its max. memory consumption would need to be accounted where it is going to be pinned, even if that pinning has not been selected by us. But it is perfectly fine to address that in another PR.
| if (blnDefPinMemory != nil) { | ||
| pinMemory = *blnDefPinMemory | ||
| } | ||
| if pinMemory { |
There was a problem hiding this comment.
I think we should let also libmem know about the new container consuming memory, even if we don't ask libmem to determine the pinning according to its own taste. Otherwise even in theory it cannot determine correctly when a node is in danger of running out of memory.
askervin
force-pushed
the
5YX_balloontype_pinmem
branch
from
a350524 to
b8d7f31
Compare
pinMemory in balloon type enables overriding pinMemory policy level option in balloon type level. Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
askervin
force-pushed
the
5YX_balloontype_pinmem
branch
from
b8d7f31 to
9fa8220
Compare
This option enables overriding policy level
pinMemoryoption in balloon types.Use cases: