-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: add golangci-lint, split PR verification into multiple jobs. #450
Conversation
Signed-off-by: Krisztian Litkey <[email protected]>
8d4cc67
to
b9527b7
Compare
Signed-off-by: Krisztian Litkey <[email protected]>
b9527b7
to
1500f73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is there any reason to split out the golangci-lint into its own workflow file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally ok, but minor question about golang versions.
- "release-*" | ||
|
||
env: | ||
GO_VERSION: "1.22.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be 1.23.x? or latest 1.22.10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that separately, consistently for everything in the repo, in a single go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can file another PR for that.
- "release-*" | ||
|
||
env: | ||
GO_VERSION: "1.22.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, should it be 1.23.x or latest 1.22.10?
Well, nothing too specific, really. I wanted for a while now to get rid of that 'project checks' workflow, and split it up to smaller, more granular jobs. And, well... there is never a better time than right now. About golangci-lint, since @kad mentioned the other day that he might want to enable other linters too, I decided to add the new golangci-lint job readily to a new lint workflow. |
maybe we can then add it to the same workflow since there is no separation in terms of when the job should be executed. (Not a blocker though, feel free to ignore it). |
I prefer to keep it separate. I want to see it as |
This patch set adds a golangci-lint worklflow. Additionally, it splits PR verification into multiple parallel jobs.