Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: add golangci-lint, split PR verification into multiple jobs. #450

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Dec 13, 2024

This patch set adds a golangci-lint worklflow. Additionally, it splits PR verification into multiple parallel jobs.

@klihub klihub requested review from kad, askervin and marquiz December 13, 2024 08:00
@klihub klihub force-pushed the devel/ci/golangci-lint branch from 8d4cc67 to b9527b7 Compare December 13, 2024 08:12
@klihub klihub force-pushed the devel/ci/golangci-lint branch from b9527b7 to 1500f73 Compare December 13, 2024 08:26
Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Is there any reason to split out the golangci-lint into its own workflow file?

Copy link
Collaborator

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally ok, but minor question about golang versions.

- "release-*"

env:
GO_VERSION: "1.22.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be 1.23.x? or latest 1.22.10?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that separately, consistently for everything in the repo, in a single go.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can file another PR for that.

- "release-*"

env:
GO_VERSION: "1.22.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, should it be 1.23.x or latest 1.22.10?

@klihub
Copy link
Collaborator Author

klihub commented Dec 13, 2024

LGTM. Is there any reason to split out the golangci-lint into its own workflow file?

Well, nothing too specific, really. I wanted for a while now to get rid of that 'project checks' workflow, and split it up to smaller, more granular jobs. And, well... there is never a better time than right now. About golangci-lint, since @kad mentioned the other day that he might want to enable other linters too, I decided to add the new golangci-lint job readily to a new lint workflow.

@fmuyassarov
Copy link
Collaborator

LGTM. Is there any reason to split out the golangci-lint into its own workflow file?

Well, nothing too specific, really. I wanted for a while now to get rid of that 'project checks' workflow, and split it up to smaller, more granular jobs. And, well... there is never a better time than right now. About golangci-lint, since @kad mentioned the other day that he might want to enable other linters too, I decided to add the new golangci-lint job readily to a new lint workflow.

maybe we can then add it to the same workflow since there is no separation in terms of when the job should be executed. (Not a blocker though, feel free to ignore it).

@klihub
Copy link
Collaborator Author

klihub commented Dec 16, 2024

LGTM. Is there any reason to split out the golangci-lint into its own workflow file?

Well, nothing too specific, really. I wanted for a while now to get rid of that 'project checks' workflow, and split it up to smaller, more granular jobs. And, well... there is never a better time than right now. About golangci-lint, since @kad mentioned the other day that he might want to enable other linters too, I decided to add the new golangci-lint job readily to a new lint workflow.

maybe we can then add it to the same workflow since there is no separation in terms of when the job should be executed. (Not a blocker though, feel free to ignore it).

I prefer to keep it separate. I want to see it as Lint / golangci-lint and not as Verify / golangci-lint in the check summary...

@askervin askervin merged commit ab71151 into containers:main Dec 17, 2024
8 checks passed
@klihub klihub deleted the devel/ci/golangci-lint branch December 17, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants