Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrumentation: golangci-lint fixes. #435

Merged

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Dec 10, 2024

Fix golangci-lint issues.

Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -99,7 +99,7 @@ func Start(m *http.ServeMux, options ...Option) error {
log.Info("starting metrics exporter...")

g, err := metrics.NewGatherer(
metrics.WithNamespace("nri"),
metrics.WithNamespace(namespace),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@askervin askervin merged commit 0c7e9f2 into containers:main Dec 11, 2024
3 checks passed
@klihub klihub deleted the fixes/golangci-lint/instrumentation branch December 11, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants