Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix build error, avoid testdata scan infinite loop. #421

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Dec 2, 2024

This PR

  • bumps the golang toolchain used when building docs
    • fixes toolchain complaining about patch-level go declaration in go.mod
  • adds an ignore rule to avoid for extracted sample sysfs test data
    • fixes sphinx-build falling into an infinite loop while scanning the source tree for docs
  • bumps the sphinx toolchain while we're at it

Don't fall into an infinite loop while scanning sample sysfs data
for tests. Ignore such data altogether instead.

Signed-off-by: Krisztian Litkey <[email protected]>
Bump golang toolchain version to avoid docs build failures with
go.mod's stating go version with patch-level detail.

Signed-off-by: Krisztian Litkey <[email protected]>
Update sphinx toolchain to 7.4.7, the latest version which
can still use sphinx_rtd_theme 2.0.0, one with support for
'display_version'.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub requested review from kad, marquiz and fmuyassarov December 2, 2024 08:10
@klihub klihub force-pushed the devel/docs/update-toolchain branch from 4a0a951 to 9920b82 Compare December 2, 2024 14:53
@klihub klihub requested a review from kad December 2, 2024 16:32
Copy link
Collaborator

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov fmuyassarov merged commit 3b69120 into containers:main Dec 3, 2024
3 checks passed
@klihub klihub deleted the devel/docs/update-toolchain branch December 3, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants