Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable race-detector in DEBUG=1 builds. #409

Merged

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Nov 12, 2024

When building with DEBUG=1, also use the '-race' golang build flag unless NORACE=1 is also set.

When building with DEBUG=1, also use the '-race' golang build
flag unless NORACE=1 is also set.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub
Copy link
Collaborator Author

klihub commented Nov 12, 2024

/cc @pfl

Copy link

@pfl pfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! LGTM.

@askervin askervin merged commit c003258 into containers:main Nov 12, 2024
3 checks passed
@klihub klihub deleted the devel/race-detector-in-debug-builds branch November 12, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants