[stacked 1/5] metrics: cleanup metrics registration, collection and gathering. #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
metrics/refactor
branch
13 times, most recently
from
a7477a6 to
14d10a3
Compare
klihub
changed the title
klihub
force-pushed
the
metrics/refactor
branch
2 times, most recently
from
ff456df to
772f60f
Compare
klihub
changed the title
klihub
force-pushed
the
metrics/refactor
branch
4 times, most recently
from
fc7babb to
7434f00
Compare
fmuyassarov
reviewed
Nov 13, 2024
klihub
changed the title
klihub
changed the title
klihub
force-pushed
the
metrics/refactor
branch
11 times, most recently
from
0dcfab6 to
d716f0f
Compare
Let me take a look at them and see how many I could address right now. |
Rework our metrics collector registry to take care of most of the necessary bits for metrics registration, collection and gathering. Use the prometheus-provided namespacing and subsystems to put all generated metrics under a prefix and provide additional grouping. Signed-off-by: Krisztian Litkey <[email protected]>
Update cgroupstats collector for the reworked metrics registry. Split out automatic registration to a register subpackage. Signed-off-by: Krisztian Litkey <[email protected]>
Remove the old resmgr-triggered polling of policy metrics and the old resmgr-level polling policy metrics collector. Implement policy metrics collection in the policy package itself. Signed-off-by: Krisztian Litkey <[email protected]>
Remove the old opencensus-based prometheus exporter. Rework prometheus exporting using our update metrics registry and a promhttp /metrics-handler. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
metrics/refactor
branch
from
d716f0f to
6cc6c62
Compare
Add configuration bits for controlling which metrics are collected. Enable collection of policy metrics by default. Signed-off-by: Krisztian Litkey <[email protected]>
Remove obsolete and unused option entries. Give a warning about using the now-obsolete '-metrics-interval' argument. It's used unconditionally by our existing Helm charts, so we'll phase it out a bit more gently. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
metrics/refactor
branch
from
6cc6c62 to
bea4468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series refactors our metrics collection code, moving most of the code to handle metrics registration, collection, and gathering into a single package in
pkg/metrics. In particular, this seriespkg/metricsresmgr,resmgr/{metrics,policycollector}policypackage itselfopencensustopromhttpfor metrics exporting inpkg/instrumentation