-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ballons: add memoryTypes to balloon types #395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
reviewed
Nov 5, 2024
askervin
force-pushed
the
5Xp_balloons_memorytype
branch
from
November 5, 2024 14:11
a0c389c
to
aa3218a
Compare
klihub
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
askervin
force-pushed
the
5Xp_balloons_memorytype
branch
from
November 5, 2024 14:27
7a484d3
to
a7c3354
Compare
fmuyassarov
reviewed
Nov 6, 2024
fmuyassarov
reviewed
Nov 7, 2024
This option enables user to define allowed memory types for containers in a balloon. Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
askervin
force-pushed
the
5Xp_balloons_memorytype
branch
from
November 7, 2024 14:23
1923b02
to
0803b6d
Compare
Switched from Pattern to XValidation CEL expression for a nice error message. |
fmuyassarov
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @askervin
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.