Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ballons: add memoryTypes to balloon types #395

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

askervin
Copy link
Collaborator

@askervin askervin commented Nov 4, 2024

No description provided.

@klihub klihub requested a review from fmuyassarov November 5, 2024 08:15
@askervin askervin force-pushed the 5Xp_balloons_memorytype branch from a0c389c to aa3218a Compare November 5, 2024 14:11
@klihub klihub self-requested a review November 5, 2024 14:17
Copy link
Collaborator

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@askervin askervin force-pushed the 5Xp_balloons_memorytype branch from 7a484d3 to a7c3354 Compare November 5, 2024 14:27
Makefile Outdated Show resolved Hide resolved
@klihub klihub requested a review from fmuyassarov November 6, 2024 19:06
This option enables user to define allowed memory types for containers
in a balloon.

Signed-off-by: Antti Kervinen <[email protected]>
@askervin askervin force-pushed the 5Xp_balloons_memorytype branch from 1923b02 to 0803b6d Compare November 7, 2024 14:23
@askervin
Copy link
Collaborator Author

askervin commented Nov 7, 2024

Switched from Pattern to XValidation CEL expression for a nice error message.

Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @askervin
LGTM

@klihub klihub merged commit a6de9ed into containers:main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants