-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: add Tiltfile for local development #382
Conversation
e3183d8
to
d9e83ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use the 'stock build infra' already offered by the repo instead of hand-rolling copies of the commands necessary to build plugin binaries or images.
I suppose this is ok, but the maintenance burden should be minimized. That is, go or docker build logic and parameterization should not be duplicated but used through |
This commit adds a Tiltfile to simplify local development with Tilt. Signed-off-by: Feruzjon Muyassarov <[email protected]>
d9e83ed
to
afc46a0
Compare
I have updated the binary build process to use the existing Makefile target. However, we can't replace the container image build process ( |
That should be fine, the docker builds/Dockerfiles use the build system. |
Do you think current state is okay to merge? |
Yes, I think it should be fine. |
ping @askervin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds a Tiltfile to simplify local development with Tilt.
How to use it?
To run balloons policy:
tilt up balloons
To run topology-aware policy:
tilt up topology-aware
All it does is: