Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add Tiltfile for local development #382

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

fmuyassarov
Copy link
Collaborator

@fmuyassarov fmuyassarov commented Oct 16, 2024

This commit adds a Tiltfile to simplify local development with Tilt.

How to use it?
To run balloons policy: tilt up balloons
To run topology-aware policy: tilt up topology-aware

All it does is:

  1. build the binary
  2. create a container image and push to a temporary registry
  3. deploy the policy Helm chart

Tiltfile Outdated Show resolved Hide resolved
Tiltfile Show resolved Hide resolved
Copy link
Collaborator

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use the 'stock build infra' already offered by the repo instead of hand-rolling copies of the commands necessary to build plugin binaries or images.

@askervin
Copy link
Collaborator

I suppose this is ok, but the maintenance burden should be minimized. That is, go or docker build logic and parameterization should not be duplicated but used through make instead.

This commit adds a Tiltfile to simplify local development with Tilt.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
@fmuyassarov
Copy link
Collaborator Author

I have updated the binary build process to use the existing Makefile target. However, we can't replace the container image build process (docker_build) with a Makefile target. The docker_build is needed for instructing Tilt on how to build the image. Without it, Tilt won't be able to trigger dependent tasks, such as deploying Kubernetes manifests into a cluster.

@fmuyassarov fmuyassarov requested a review from klihub October 16, 2024 12:09
@klihub
Copy link
Collaborator

klihub commented Oct 16, 2024

However, we can't replace the container image build process (docker_build) with a Makefile target. The docker_build is needed for instructing Tilt on how to build the image. Without it, Tilt won't be able to trigger dependent tasks, such as deploying Kubernetes manifests into a cluster.

That should be fine, the docker builds/Dockerfiles use the build system.

@fmuyassarov
Copy link
Collaborator Author

However, we can't replace the container image build process (docker_build) with a Makefile target. The docker_build is needed for instructing Tilt on how to build the image. Without it, Tilt won't be able to trigger dependent tasks, such as deploying Kubernetes manifests into a cluster.

That should be fine, the docker builds/Dockerfiles use the build system.

Do you think current state is okay to merge?

@klihub
Copy link
Collaborator

klihub commented Oct 16, 2024

However, we can't replace the container image build process (docker_build) with a Makefile target. The docker_build is needed for instructing Tilt on how to build the image. Without it, Tilt won't be able to trigger dependent tasks, such as deploying Kubernetes manifests into a cluster.

That should be fine, the docker builds/Dockerfiles use the build system.

Do you think current state is okay to merge?

Yes, I think it should be fine.

@fmuyassarov
Copy link
Collaborator Author

ping @askervin

Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@askervin askervin merged commit 0320dde into containers:main Oct 17, 2024
3 checks passed
@fmuyassarov fmuyassarov deleted the dev-ex-tilt branch October 17, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants