Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmem: typo and thinko fixes. #381

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Oct 14, 2024

This patch set fixes

  • a docstring/comment typo
  • node mask parsing of empty masks
  • node mask parsing ID range upper boundary (should be inclusive)
  • node mask parsing incorrect slice index for single node IDs

It also adds an obviously necessary minimal test for ParseNodeMask().

@klihub klihub force-pushed the fixes/libmem branch 2 times, most recently from 5095902 to 10148d8 Compare October 14, 2024 16:15
Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub marked this pull request as draft October 15, 2024 08:08
@klihub klihub marked this pull request as ready for review October 15, 2024 08:09
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@askervin askervin merged commit 82025f6 into containers:main Oct 15, 2024
3 checks passed
@klihub klihub deleted the fixes/libmem branch October 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants