helm: add workaround for Helm int/float snafu. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm is struggling with a regression where integer values get converted to float64 and therefore fail to get later properly injected into templates. For us this hits our integer [nri.]pluginIndex values. Add a workaround to first force plugin indices to integers before injecting them through templates. See helm/helm@44a81f63 for more details. Signed-off-by: Krisztian Litkey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm is struggling with a regression where integer values get converted to float64 and therefore fail to get later properly injected into templates. For us this hits our integer [nri.]pluginIndex values.
Add a workaround to first force plugin indices to integers before injecting them through templates.
See helm/helm@44a81f63 for more details.
The other alternative considered was this in
values.schema.json:Since indices are integers and the above alternative would have also required us to always quote indices in
values.yaml, this simpler choice of representing integer indices as integer values was chosen.