Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize: replace patchesStrategicMerge by patches #242

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

fmuyassarov
Copy link
Collaborator

Use patches instead of patchesStrategicMerge with kustomize as patchesStrategicMerge is deprecated.

Use patches instead of patchesStrategicMerge with kustomize as
patchesStrategicMerge is deprecated.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
@fmuyassarov fmuyassarov requested review from klihub and marquiz January 25, 2024 15:25
Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, how is this different from #243?

@fmuyassarov
Copy link
Collaborator Author

this is for main branch and the other for release branch. But I should correct the PR name for the other.

Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for main branch and the other for release branch. But I should correct the PR name for the other.

Ah, of course 🤦‍♂️

LGTM

@klihub klihub merged commit d276112 into containers:main Jan 25, 2024
2 checks passed
@fmuyassarov fmuyassarov deleted the kustomize-fix branch July 5, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants