Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preferCloseToDevices balloon type option #203

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Add preferCloseToDevices balloon type option #203

merged 5 commits into from
Dec 15, 2023

Conversation

askervin
Copy link
Collaborator

Passing E2E tests requires:

@askervin
balloons: add options for creating balloons close to devices
1016427 
- Add preferCloseToDevices in the ballooons CRD for explicit
  configuration.
- Add implicit PreferFarFromDevices option to BalloonType
  definition. This anti-affinity list is filled based on affinities
  of this and other balloon types. If necessary in the future, we
  can enable explicit anti-affinities in CRDs, too.
- If a balloon type has either of these preferences defined,
  use the balloon type specific CPU tree allocator that will
  implement the logic behind these options.

Signed-off-by: Antti Kervinen <[email protected]>
@askervin askervin force-pushed the 5S8_balloons_close_split branch from 28920e4 to 2fb04cd Compare November 28, 2023 14:34
@askervin askervin marked this pull request as ready for review November 28, 2023 15:21
@askervin askervin mentioned this pull request Nov 28, 2023
Merged
@klihub klihub requested review from kad, marquiz and fmuyassarov December 7, 2023 14:57
kad
kad approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me. Might be improvement for later to support globs. e.g. /dev/foo*

@klihub
Copy link
Collaborator

klihub commented Dec 15, 2023

nit: there is a repetition of 'affecting' in the commit message.

@askervin
balloons: implement device affinity/anti-affinity CPU allocation
ed991ac 
- Change CPU tree allocator to use a chain of ResizeCpus() functions
  to avoid hardcoding the order in which various aspects affecting CPU
  allocation are taken into account. Without the chain structure every
  level of ResizeCpus() would need to know what is the next level of
  importance in CPU allocation.

Signed-off-by: Antti Kervinen <[email protected]>
@askervin
balloons: document the preferCloseToDevices option
c34742a 
Signed-off-by: Antti Kervinen <[email protected]>
@askervin
e2e: add test for balloons preferCloseToDevices
1dd35bd 
Signed-off-by: Antti Kervinen <[email protected]>
@askervin
balloons: add unit test for balloons device affinity
f1a7dc4 
Signed-off-by: Antti Kervinen <[email protected]>
@askervin askervin force-pushed the 5S8_balloons_close_split branch from 2fb04cd to f1a7dc4 Compare December 15, 2023 13:58
@askervin
Copy link
Collaborator Author

nit: there is a repetition of 'affecting' in the commit message.

Thanks, fixed!

@kad kad merged commit ca7c4f8 into containers:main Dec 15, 2023
3 checks passed
@askervin askervin mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klihub klihub klihub approved these changes

@kad kad kad approved these changes

@marquiz marquiz Awaiting requested review from marquiz

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@askervin @klihub @kad