Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: introduce affinity to select specific nodes for the DaemonSet #196

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

fmuyassarov
Copy link
Collaborator

This patch allows users to define custom affinity rules in values.yaml, specifying preferred nodes for plugin DaemonSet Pods. Follows Kubernetes structure for affinity fields.

Copy link
Collaborator

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I just wonder if we should also add support for simple label-based nodeSelectors ?

Allow users to define custom affinity rules in values.yaml, specifying
preferred nodes for plugin DaemonSet Pods. Follows Kubernetes structure
for affinity fields.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
@fmuyassarov
Copy link
Collaborator Author

This LGTM. I just wonder if we should also add support for simple label-based nodeSelectors ?

Done.

@fmuyassarov fmuyassarov requested a review from klihub November 18, 2023 11:49
@klihub klihub merged commit be77baf into containers:main Nov 18, 2023
3 checks passed
@fmuyassarov fmuyassarov deleted the affinity branch November 19, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants