Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.2] test/e2e: fix incorrect Allocat[ion|or]Priority config key. #190

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Nov 3, 2023

Fix incorrect config keys in balloons tests. Use more consistent test environment variable names wrt. config keys.

@klihub klihub changed the title test/e2e: fix incorrect Allocat[ion|or]Priority config key. [release-0.2] test/e2e: fix incorrect Allocat[ion|or]Priority config key. Nov 3, 2023
And also use more consistent naming in the environment wrt.
the actual configuration key.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub force-pushed the fixes/release-0.2 branch from 83197af to deb5edf Compare November 3, 2023 11:37
@klihub klihub requested a review from askervin November 3, 2023 11:44
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @klihub

@askervin
Copy link
Collaborator

askervin commented Nov 3, 2023

(I've got backport to CRI-RM tests running...)

Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marquiz marquiz merged commit 88ce4f1 into containers:release-0.2 Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants