config-manager: don't crash if no runtime is found running. #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
fixes/config-manager
branch
from
fd62089 to
44995dc
Compare
Signed-off-by: Krisztian Litkey <[email protected]>
Use a single D-Bus connection for both listing and restarting runtime units. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/config-manager
branch
from
44995dc to
dbe717a
Compare
It looks like in the case of CRI-O we need to give it some time after we have been started up but before we kick it in the head to restart it over D-Bus. Otherwise it will always report a 255 (-1) exit status for us. Since we run as an init-container, a non-zero exit status would prevent other containers in our pod from ever starting up. It would be good to try and find out what is the exact reason why this behavior is exhibited by CRI-O but not containerd, and if it could be fixed in CRI-O. Until then... this. Signed-off-by: Krisztian Litkey <[email protected]>
marquiz
approved these changes
Oct 26, 2023
fmuyassarov
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
LGTM
Thanks @klihub . I will spend some time to really understand why is the real culprit in the CRI-O.
But for now, I also agree that this is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.