Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.2] helm: add an option to set tolerations (backport of #157) #178

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Oct 25, 2023

In some clusters, some of the Nodes might have taints which may avoid NRI plugins DaemonSet Pods not to get scheduled on those Nodes. Having an option to pass custom tolerations to plugins DaemonSet object would help to ensure that Pods get scheduled on all the desired Nodes.

In some clusters, some of the Nodes might have taints which may
avoid NRI plugins DaemonSet Pods not to get scheduled on those
Nodes. Having an option to pass custom tolerations to plugins
DaemonSet object would help to ensure that Pods get scheduled
on all the desired Nodes.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
@klihub klihub requested review from fmuyassarov and marquiz October 25, 2023 09:12
@klihub
Copy link
Collaborator Author

klihub commented Oct 25, 2023

@fmuyassarov @marquiz Should we cherry-pick this, too ?

@klihub klihub changed the title [release-0.2] helm: add an option to set tolerations [backport of #157) [release-0.2] helm: add an option to set tolerations (backport of #157) Oct 25, 2023
@klihub klihub marked this pull request as ready for review October 25, 2023 11:02
Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think it is good to have this too.

@fmuyassarov fmuyassarov merged commit c708a54 into containers:release-0.2 Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants