-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix md style #172
docs: fix md style #172
Conversation
b88be83
to
314911a
Compare
@marquiz I think this could be a good idea. What would be the best way to hook this in, as this is not a github workflow ? Should we run it as part of the containerized doc build ? That would automatically buy us a local check for free. |
Okay, actually there is a github action for it... |
That or then just have a shell script action |
Fix the following issues raised by markdownlint: - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md004---unordered-list-style - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md005---inconsistent-indentation-for-list-items-at-the-same-level - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md006---consider-starting-bulleted-lists-at-the-beginning-of-the-line - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md009---trailing-spaces - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md010---hard-tabs - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md012---multiple-consecutive-blank-lines - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md013---line-length - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md031---fenced-code-blocks-should-be-surrounded-by-blank-lines - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md032---lists-should-be-surrounded-by-blank-lines - https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md040---fenced-code-blocks-should-have-a-language-specified Signed-off-by: Markus Lehtonen <[email protected]>
314911a
to
7712e53
Compare
Rebased, plus two small whitespaces fixes. Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have the markdownlinter enabled as precheck at least for docs directory related PRs.
LGTM
Fix the following issues raised by markdownlint:
Inspired by #169. If you like this idea we could enable markdownlint in the CI.