Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix md style #172

Merged
merged 1 commit into from
Oct 24, 2023
Merged

docs: fix md style #172

merged 1 commit into from
Oct 24, 2023

Conversation

@marquiz marquiz force-pushed the devel/docs-mdlint branch 2 times, most recently from b88be83 to 314911a Compare October 24, 2023 09:05
@klihub
Copy link
Collaborator

klihub commented Oct 24, 2023

@marquiz I think this could be a good idea.

What would be the best way to hook this in, as this is not a github workflow ? Should we run it as part of the containerized doc build ? That would automatically buy us a local check for free.

@klihub
Copy link
Collaborator

klihub commented Oct 24, 2023

@marquiz I think this could be a good idea.

What would be the best way to hook this in, as this is not a github workflow ? Should we run it as part of the containerized doc build ? That would automatically buy us a local check for free.

Okay, actually there is a github action for it...

@marquiz
Copy link
Collaborator Author

marquiz commented Oct 24, 2023

Okay, actually there is a github action for it...

That or then just have a shell script action

@marquiz marquiz marked this pull request as ready for review October 24, 2023 12:05
@marquiz
Copy link
Collaborator Author

marquiz commented Oct 24, 2023

Rebased, plus two small whitespaces fixes. Ready for review

Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have the markdownlinter enabled as precheck at least for docs directory related PRs.
LGTM

@klihub klihub merged commit e6fdda5 into containers:main Oct 24, 2023
3 checks passed
@marquiz marquiz deleted the devel/docs-mdlint branch October 24, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants