Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment/helm: always use DirectoryOrCreate for /var/run/nri. #162

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Oct 17, 2023

Use DirectoryOrCreate hostPath type for /var/run/nri in those Helm charts that are not set up like that yet. This should fix failures when NRI in the runtime is enabled by the config-manager init-container, so the /var/run/nri does not exist yet.

Use DirectoryOrCreate hostPath type for /var/run/nri. This
should fix failures when NRI in the runtime is enabled by
the config-manager init-container, so the /var/run/nri does
not exist yet.

Signed-off-by: Krisztian Litkey <[email protected]>
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@askervin
Copy link
Collaborator

Thanks @klihub!

Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov fmuyassarov merged commit a5bbd52 into containers:main Oct 17, 2023
3 checks passed
@klihub klihub deleted the fixes/nri-socket-hostpath-type branch October 18, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants