fixes: fix image tagging scheme in publishing workflow. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
klihub
commented
Oct 16, 2023
•
klihub
commented
- use 'v'-prefixed image version tags
- use 'v'-prefixed versions in binaries
klihub
force-pushed
the
fixes/workflows/image-tagging
branch
from
98ae086 to
c300630
Compare
klihub
force-pushed
the
fixes/workflows/image-tagging
branch
from
c300630 to
e7dd6a1
Compare
Don't strip the 'v' prefix from version tags. For consistency, also inject a leading 'v' prefix to versions derived from release branch names. IOW, call the image generated from the tip of a release-0.2 branch 'v0.2-unstable' instead of '0.2-unstable'. Signed-off-by: Krisztian Litkey <[email protected]>
Use a 'v' prefix in the version strings linked into binaries. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/workflows/image-tagging
branch
from
e7dd6a1 to
a5f7ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.