fixes: fix a bunch of problems in bootstrapping e2e tests. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2023
klihub
force-pushed
the
fixes/e2e-tests
branch
2 times, most recently
from
f0af2d0 to
3c11d1e
Compare
fmuyassarov
reviewed
Oct 13, 2023
askervin
reviewed
Oct 13, 2023
klihub
force-pushed
the
fixes/e2e-tests
branch
4 times, most recently
from
525db31 to
0688ca6
Compare
Signed-off-by: Krisztian Litkey <[email protected]>
Allow installing containerd or CRI-O from a release tarball or pre-compiled sources. Default to installing from release tarballs. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/e2e-tests
branch
from
0688ca6 to
60bcba0
Compare
Instead, install service file from release tarball, sources, or using a documented online URL. Signed-off-by: Krisztian Litkey <[email protected]>
Do not try to unconditionally overwrite /etc/resolv.conf with $dns_nameserver as the server. If it is unset, don't touch resolv.conf at all. Signed-off-by: Krisztian Litkey <[email protected]>
Load plugin images for CRI-O using a single podman import instead of an import and a podman scp. Fix plugin image reference patching in test deployment files. Signed-off-by: Krisztian Litkey <[email protected]>
And make the bridge plugin the default. Signed-off-by: Krisztian Litkey <[email protected]>
Using the bridge plugins seems to break metrics collection tests. Revert the default to cilium for now until we figure out what's wrong and fix it. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
klihub
force-pushed
the
fixes/e2e-tests
branch
from
60bcba0 to
f4c685f
Compare
fmuyassarov
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Thanks @klihub . LGTM
I must admit that I haven't verified changes by running e2e myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set fixes a bunch of problems and otherwise improves bootstrapping e2e tests. Among other things: