Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: don't set image.tag in values.yaml #127

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

marquiz
Copy link
Collaborator

@marquiz marquiz commented Oct 10, 2023

This way the default is to fallback to appVersion from the Chart.yaml.

Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This way the default is to fallback to appVersion from the Chart.yaml.

Signed-off-by: Markus Lehtonen <[email protected]>
@marquiz
Copy link
Collaborator Author

marquiz commented Oct 10, 2023

ping @klihub @askervin

@fmuyassarov fmuyassarov merged commit b5ebb2e into containers:main Oct 10, 2023
3 checks passed
@marquiz marquiz deleted the devel/helm branch October 10, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants