balloons: add PreferSpreadOnPhysicalCores #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
askervin
commented
Oct 6, 2023
askervin
commented
- Enable using different CPU allocators in different balloon types. So far the same CPU allocator was used with the same options for all CPU allocations in the policy.
- Add new PreferSpreadOnPhysicalCores option to toggle CPU allocations packing or spreading on physical CPU cores. This option is specific to balloon type with a policy level default.
- Make existing AllocatorTopologyBalancing option specific to balloon type, too.
askervin
force-pushed
the
5RG_balloons_preferspreadonphysicalcores
branch
from
3a2e08a to
83868ec
Compare
|
@askervin Please add the missing sign-offs ? |
askervin
force-pushed
the
5RG_balloons_preferspreadonphysicalcores
branch
from
83868ec to
1acfe02
Compare
|
@askervin Thats 1 out of 2 ;-) If you could fix the other commit, too ? |
- Enable using different CPU allocators in different balloon types. So far the same CPU allocator was used with the same options for all CPU allocations in the policy. - Add new PreferSpreadOnPhysicalCores option to toggle CPU allocations packing or spreading on physical CPU cores. This option is specific to balloon type with a policy level default. - Make existing AllocatorTopologyBalancing option specific to balloon type, too. Signed-off-by: Antti Kervinen <[email protected]>
The goal of this patch is to use the same e2e test numbers in nri-resource-policy and cri-resource-manager e2e tests for the balloons policy. This makes it easier to keep e2e tests in sync when porting policy features between these projects. Now test[01]* are common e2e tests for both projects, and test2* are nri-policy-specific e2e tests. Signed-off-by: Antti Kervinen <[email protected]>
askervin
force-pushed
the
5RG_balloons_preferspreadonphysicalcores
branch
from
1acfe02 to
7c72019
Compare
klihub
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.