deployment: fix the nri volume type to DirectoryOrCreate #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the NRI feature is not enable yet in the runtime, runnig Helm charts with nri.patchContainerdConfig parameter set to true will fail because the directory is not created yet. Setting the hostPath volume type to DirectoryOrCreate ensures that we get the directory created in case it's missing. Signed-off-by: Feruzjon Muyassarov <[email protected]>
klihub
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the NRI feature is not enable yet in the runtime, runnig Helm charts with
nri.patchContainerdConfigparameter set to true will fail because the directory is not created yet. Setting the hostPath volume type to DirectoryOrCreate ensures that we get the directory created in case it's missing.