deployment: refactor config manager to support NRI enabling in CRI-O #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmuyassarov
force-pushed
the
crio-nri
branch
2 times, most recently
from
18984c0 to
996e2d4
Compare
klihub
reviewed
Sep 29, 2023
|
just as an idea: would it make sense to try to autodetect? |
fmuyassarov
changed the title
Done. PTAL |
fmuyassarov
force-pushed
the
crio-nri
branch
2 times, most recently
from
4f760f8 to
1f639c0
Compare
|
Rebased on top of the latest main. |
klihub
reviewed
Oct 5, 2023
klihub
reviewed
Oct 5, 2023
klihub
reviewed
Oct 6, 2023
klihub
approved these changes
Oct 6, 2023
|
cc @marquiz |
|
Rebased. |
marquiz
reviewed
Oct 10, 2023
marquiz
reviewed
Oct 11, 2023
This commit extends config manager code and the plugins helm charts so that CRI-O users are also able to enable NRI via our charts if they wish to. Same parameter is used to opt in for the feature in Helm charts and we don't require users to indicate what container runtime is being used. Instead the config manager auto-detects the runtime and does the necessary changes to its configuration file. In scenarios with multiple active runtimes (e.g., CRI-O and containerd), the manager gracefully exits and throws an error. Signed-off-by: Feruzjon Muyassarov <[email protected]>
marquiz
approved these changes
Oct 11, 2023
Regardless of that, can we perhaps proceeding merging this PR if it looks good enough. And for adding init container to memtierd and memory-qos can be done as separate PR? |
Let's do that. |
|
submitted #131 for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends config manager code and the plugins helm charts
so that CRI-O users are also able to enable NRI via our charts if they
wish to. Same parameter is used to opt in for the feature in Helm
charts and we don't require users to indicate what container runtime
is being used. Instead the config manager auto-detects the runtime
and does the necessary changes to its configuration file. In scenarios
with multiple active runtimes (e.g., CRI-O and containerd), the
manager gracefully exits and throws an error.