resmgr/control: golangci-lint fixes.

Signed-off-by: Krisztian Litkey <[email protected]>

pkg/resmgr/control/control.go

@@ -17,7 +17,6 @@ package control
 import (
 	"errors"
 	"fmt"
-	"os"
 	"sort"
 	"strings"
 
@@ -27,15 +26,6 @@ import (
 	cfgapi "github.com/containers/nri-plugins/pkg/apis/config/v1alpha1/resmgr/control"
 )
 
-const (
-	// EnvVarEnableTestAPIs controls if test APIS are enabled (currently e2e test controller).
-	EnvVarEnableTestAPIs = "ENABLE_TEST_APIS"
-)
-
-var (
-	enableTestAPIs = (os.Getenv(EnvVarEnableTestAPIs) != "")
-)
-
 // Control is the interface for triggering controller-/domain-specific post-decision actions.
 type Control interface {
 	// StartStopControllers starts/stops all controllers according to configuration.

pkg/resmgr/control/cpu/cache.go

@@ -45,12 +45,11 @@ func setClassAssignments(c cache.Cache, a *cpuClassAssignments) {
 
 // Set the value of cached cpuClassAssignments
 func (c *cpuClassAssignments) Set(value interface{}) {
-	switch value.(type) {
+	switch v := value.(type) {
 	case cpuClassAssignments:
-		*c = value.(cpuClassAssignments)
+		*c = v
 	case *cpuClassAssignments:
-		cp := value.(*cpuClassAssignments)
-		*c = *cp
+		*c = *v
 	}
 }
 

pkg/resmgr/control/cpu/cpu.go

@@ -295,5 +295,8 @@ func (ctl *cpuctl) getClasses() map[string]Class {
 
 // Register us as a controller.
 func init() {
-	control.Register(CPUController, "CPU controller", getCPUController())
+	err := control.Register(CPUController, "CPU controller", getCPUController())
+	if err != nil {
+		log.Warnf("failed to register CPU controller: %v", err)
+	}
 }

pkg/resmgr/control/e2e-test/e2e-test.go

@@ -154,5 +154,8 @@ func (ctl *testctl) registerHandler() {
 
 // Register us as a controller.
 func init() {
-	control.Register(ControllerName, "Test controller", getE2ETestController())
+	err := control.Register(ControllerName, "Test controller", getE2ETestController())
+	if err != nil {
+		log.Warnf("failed to register controller: %v", err)
+	}
 }