-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add a metrics/collectors subpackage. When imported it pulls in and registers the fairly standard buildinfo, process and golang runtime collectors. Also update cgroupstats collector for the reworked metrics registry and split out automatic registration to a register subpackage. Signed-off-by: Krisztian Litkey <[email protected]>
- Loading branch information
Showing
3 changed files
with
103 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // Copyright The NRI Plugins Authors. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package collectors | ||
|
|
||
| import ( | ||
| "github.com/containers/nri-plugins/pkg/cgroupstats" | ||
| logger "github.com/containers/nri-plugins/pkg/log" | ||
| "github.com/containers/nri-plugins/pkg/metrics" | ||
| ) | ||
|
|
||
| var ( | ||
| log = logger.Get("collectors") | ||
| ) | ||
|
|
||
| func init() { | ||
| err := metrics.Register( | ||
| cgroupstats.NewCollector(), | ||
| metrics.WithGroup("cgroup"), | ||
| metrics.WithCollectorOptions( | ||
| metrics.WithName("stats"), | ||
| metrics.WithoutNamespace(), | ||
| ), | ||
| ) | ||
| if err != nil { | ||
| log.Error("failed register cgroup/stats collector: %v", err) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // Copyright The NRI Plugins Authors. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package collectors | ||
|
|
||
| import ( | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/client_golang/prometheus/collectors" | ||
|
|
||
| logger "github.com/containers/nri-plugins/pkg/log" | ||
| "github.com/containers/nri-plugins/pkg/metrics" | ||
| ) | ||
|
|
||
| var ( | ||
| log = logger.Get("metrics") | ||
| ) | ||
|
|
||
| func init() { | ||
| var ( | ||
| collectors = map[string]prometheus.Collector{ | ||
| "buildinfo": collectors.NewBuildInfoCollector(), | ||
| "golang": collectors.NewGoCollector(), | ||
| "process": collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}), | ||
| } | ||
| options = []metrics.RegisterOption{ | ||
| metrics.WithGroup("misc"), | ||
| metrics.WithCollectorOptions( | ||
| metrics.WithoutNamespace(), | ||
| metrics.WithoutSubsystem(), | ||
| ), | ||
| } | ||
| ) | ||
|
|
||
| for name, collector := range collectors { | ||
| if err := metrics.Register( | ||
| collector, | ||
| append( | ||
| append([]metrics.RegisterOption{}, options...), | ||
| metrics.WithCollectorOptions(metrics.WithName(name)), | ||
| )..., | ||
| ); err != nil { | ||
| log.Error("failed to register %s collector: %v", name, err) | ||
| } | ||
| } | ||
| } |