Skip to content

Commit

Permalink
image: improve workflow to enforce semver versioning for the bundle
Browse files Browse the repository at this point in the history
Previously, the image building workflow used  an 'unknown' tag for
all container images and the bundle. However, bundle should strictly
follow semantic versioning (semver). This commit introduces the use
of the 'v0.0.0-unknown' tag instead of 'unknown'.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
  • Loading branch information
fmuyassarov authored and klihub committed Dec 22, 2023
1 parent 75dc0ea commit 61b0d6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ KUBERNETES_VERSION := $(shell grep 'k8s.io/kubernetes ' go.mod | sed 's/^.* //')

# Directories (in cmd) with go code we'll want to create Docker images from.
IMAGE_DIRS = $(shell find cmd -name Dockerfile | sed 's:cmd/::g;s:/.*::g' | uniq)
IMAGE_VERSION := $(shell git describe --dirty 2> /dev/null || echo unknown)
IMAGE_VERSION := $(shell git describe --dirty 2> /dev/null || echo v0.0.0-unknown)
ifdef IMAGE_REPO
override IMAGE_REPO := $(IMAGE_REPO)/
endif
Expand Down

0 comments on commit 61b0d6d

Please sign in to comment.