Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipam, network: implement IPAM management #862

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Dec 6, 2023

This PR intends to add IPAM Management code to netavark. Currently PR is in progress.

[NO NEW TESTS NEEDED]

This PR intends to add IPAM Management code to netavark.
Currently PR is in progress.

[NO NEW TESTS NEEDED]

Signed-off-by: Aditya R <[email protected]>
Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flouthoc
Copy link
Collaborator Author

This PR has top level functions to create IPAM schema and make necessary queries needed for porting code from https://github.com/containers/common/blob/main/libnetwork/netavark/ipam.go to netavark.

Pending in this PR and still needs to be done.

  • Ipam mod must port and implement logic from c/common and then remove logic/code from c/common. As a result IPAM management will be done by netavark itself and not podman.

Note: Netavark is already getting all the needed bits from podman in its config so till now I suspect no new config changes are needed for netavark end.

PS: Not working on this now but if possible I'd love to pick this up again in future and do it as per my convenience/bandwidth if this is not on high priority 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants