fix aardvark output logic

When we have debug level we want stderr connected. If this is not the case we should use /dev/null. Also do not connect stdin and use Stdio::inherit() instead of the unsafe call. Signed-off-by: Paul Holzinger <[email protected]>
containers · Feb 11, 2022 · e915318 · e915318
1 parent 6d59e4e
commit e915318
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/dns/aardvark.rs b/src/dns/aardvark.rs
@@ -10,7 +10,6 @@ use std::io::prelude::*;
 use std::io::Result;
 use std::net::IpAddr;
 use std::net::Ipv4Addr;
-use std::os::unix::prelude::FromRawFd;
 use std::path::Path;
 use std::process::{Command, Stdio};
 
@@ -103,12 +102,13 @@ impl Aardvark {
         log::debug!("start aardvark-dns: {:?}", aardvark_args);
 
         let output = match log_enabled!(log::Level::Debug) {
-            true => Stdio::null(),
-            false => unsafe { Stdio::from_raw_fd(2) },
+            true => Stdio::inherit(),
+            false => Stdio::null(),
         };
 
         Command::new(&aardvark_args[0])
             .args(&aardvark_args[1..])
+            .stdin(Stdio::null())
             .stdout(Stdio::null())
             .stderr(output)
             // set RUST_LOG for aardvark