Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce oci/{archive,layout}.ImageNotFoundError #1675

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 6, 2022

… for containers/skopeo#1757 .

Warning: Absolutely untested.

Copy link
Contributor

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for doing this!

@mtrmac
Copy link
Collaborator Author

mtrmac commented Oct 6, 2022

(It would be fair for this to only go in after #1381, which has been pending for a long time — so that that PR is not forced to deal with one more feature. Let me see if I can make progress on that one now.)

@mtrmac
Copy link
Collaborator Author

mtrmac commented Oct 11, 2022

Looking at #1381, it needs a few more changes — so let’s not block this one on it.

@rhatdan
Copy link
Member

rhatdan commented Oct 12, 2022

LGTM

@rhatdan rhatdan merged commit 191b7a3 into containers:main Oct 12, 2022
@mtrmac mtrmac deleted the oci-not-found branch October 12, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants