Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: inet.af/tcpproxy -> github.com/inetaf/tcpproxy #399

Closed
wants to merge 1 commit into from

Conversation

AkihiroSuda
Copy link
Contributor

The `inet.af` domain was lost (inetaf/tcpproxy issue 39).

Signed-off-by: Akihiro Suda <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AkihiroSuda
Once this PR has been reviewed and has the lgtm label, please assign cfergeau for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau
Copy link
Collaborator

This one is tricky, we did the switch to github.com/inetaf/tcpproxy in commit 600910c, but this caused a regression in gvproxy/podman, so we reverted it in #386
The replace inet.af/tcpproxy => github.com/inetaf/tcpproxy v0.0.0-20221017015627-91f861402626 in go.mod is supposed to paper over this issue, but given you opened this PR, this must not be enough?

@AkihiroSuda
Copy link
Contributor Author

Thanks, replace is enough for now, but I hope that eventually gvisor-tap-vsock can switch to the latest upstream (or just fork it under non-.af TLD)

@jandubois
Copy link

The replace inet.af/tcpproxy => github.com/inetaf/tcpproxy v0.0.0-20221017015627-91f861402626 in go.mod is supposed to paper over this issue, but given you opened this PR, this must not be enough?

@cfergeau The problem with replace is that it only affects the main module; it is not inherited just by using gvisor-tap-vsock and it's go.mod:

exclude and replace directives only operate on the current (“main”) module. exclude and replace directives in modules other than the main module are ignored when building the main module. The replace and exclude statements, therefore, allow the main module complete control over its own build, without also being subject to complete control by dependencies.
-- Go Wiki: Go Modules

So every program using gvisor-tap-vsock, even if just indirectly, will have to copy the replace directive into their own go.mod file to have any effect.

@AkihiroSuda
Copy link
Contributor Author

Alternative: mv vendor/inet.af/tcpproxy/tcpproxy.go to pkg/tcpproxy/tcpproxy.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants