Update golangci-lint to v1.60.1 #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
force-pushed
the
linter
branch
2 times, most recently
from
11cc971 to
922f619
Compare
While golangci/golangci-lint-action is convenient to use, it has the side-effect of always using the latest golangci-lint release, which can introduce new failures at any time. If we use `make lint`, the golangci-lint version we tested with will be used, and we can control when to updated to newer golangci-lint version, and address the new warnings. For example, golangci-lint v1.60.2 introduces new checks for int overflows, which I'd rather address at a later time. Signed-off-by: Christophe Fergeau <[email protected]>
There's a v1.60.2 release, but it triggers multiple warnings about integer overflows which I prefer to address at a later time. Signed-off-by: Christophe Fergeau <[email protected]>
This fixes cmd/gvproxy/main.go:106:12: printf: non-constant format string in call to github.com/sirupsen/logrus.Infof (govet) log.Infof(version.String()) ^ make: *** [Makefile:49: lint] Error 1 Signed-off-by: Christophe Fergeau <[email protected]>
test/basic_test.go has some DNS resolution tests for various types of DNS records. These tests use wikipedia.org or google.com, which means they have to be updated once in a while when the admins of these sites decide to change these records. Lately this has happened a few times with wikipedia SRV and MX record. This commit switches to crc.dev for these tests, as it's a domain we control, and thus we have more control over DNS record changes. Signed-off-by: Christophe Fergeau <[email protected]>
cfergeau
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cfergeau
commented
Aug 22, 2024
| @@ -1,192 +1,190 @@ | |||
| module github.com/containers/gvisor-tap-vsock/tools | |||
|
|
|||
| go 1.20 | |||
| go 1.22.1 | |||
There was a problem hiding this comment.
For what it's worth, this can be problematic on systems still using go 1.21 as make cross needs the makefat binary, which is built through tools/go.mod.
golangci-lint v1.59.1 is the last golangci-lint version supporting go 1.21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a lint error which shows in CI.