Add log-file to proxy builder #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
requested changes
Jan 18, 2024
|
@cfergeau and i talked about this PR; I'm going to add a little "Seed" information to the logs as the first entry ... hold tight until i add that for merge |
The original PR only enabled log-file on the command line. This PR adds log-file to gvproxy's builder (for consumption) and adds trivial test. Also, when --debug is used, we seed the log file with some environment information Signed-off-by: Brent Baude <[email protected]>
|
LGTM @cfergeau PTAL |
cfergeau
approved these changes
Jan 29, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e948514
into
containers:main
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR only enabled log-file on the command line. This PR adds log-file to gvproxy's builder (for consumption) and adds trivial test.