Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: More vfkit updates #263

Merged
merged 1 commit into from
Sep 7, 2023
Merged

README: More vfkit updates #263

merged 1 commit into from
Sep 7, 2023

Conversation

cfergeau
Copy link
Collaborator

No description provided.

@baude
Copy link
Member

baude commented Sep 2, 2023

lgtm

@cfergeau
README: More vfkit updates
8d1f742 
Signed-off-by: Christophe Fergeau <[email protected]>
@cfergeau
Copy link
Collaborator Author

cfergeau commented Sep 6, 2023

(based on Brent's lgtm, this is only a README change - I've fixed the missing DCO reported by CI)
/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

@cfergeau: you cannot LGTM your own PR.

In response to this:

(based on Brent's lgtm, this is only a README change - I've fixed the missing DCO reported by CI)
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfergeau
Copy link
Collaborator Author

cfergeau commented Sep 6, 2023

/approve

@gbraad
Copy link
Member

gbraad commented Sep 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 7, 2023
gbraad
gbraad approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/appove

praveenkumar
praveenkumar approved these changes Sep 7, 2023
View reviewed changes
README.md
```
(terminal 1) $ bin/gvproxy -debug -listen unix:///tmp/network.sock --listen-vfkit unixgram:///tmp/vfkit.sock
(terminal 2) $ vfkit (all your vfkit options) --device virtio-net,unixSocketPath=/tmp/vfkit.sock,mac=5a:94:ef:e4:0c:ee
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, gbraad, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@praveenkumar praveenkumar merged commit 39a1226 into containers:main Sep 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenkumar praveenkumar praveenkumar approved these changes

@gbraad gbraad gbraad approved these changes

Assignees

@gbraad gbraad

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfergeau @baude @gbraad @praveenkumar