Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packit/RPM: Initial add of config and rpm spec #15

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Packit/RPM: Initial add of config and rpm spec #15

merged 1 commit into from
Jan 26, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jan 16, 2024 •
edited
Loading

Include validate and unit tests using TMT.

Also cleanup a leftover double quote in test.sh from previous commit.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5 lsm5 marked this pull request as draft January 16, 2024 11:35
@lsm5 lsm5 force-pushed the packit-rpm branch 4 times, most recently from d448e14 to ff5973a Compare January 16, 2024 12:00
rhatdan
rhatdan reviewed Jan 16, 2024
View reviewed changes
.packit.yaml Outdated Show resolved Hide resolved
@lsm5 lsm5 force-pushed the packit-rpm branch 6 times, most recently from dbda63c to 30e4cd8 Compare January 17, 2024 15:21
@lsm5
Copy link
Member Author

lsm5 commented Jan 17, 2024

rust on rhel9 is 1.71 while crun-vm needs 1.74. Disabling epel build targets for now.

@lsm5 lsm5 marked this pull request as ready for review January 17, 2024 15:44
@lsm5
Copy link
Member Author

lsm5 commented Jan 17, 2024

Good to go. rpm built in copr installs /usr/bin/crun-vm. Once this is merged, crun-vm will be built automatically on rhcontainerbot/podman-next after each commit to main. Might wanna review and merge #14 first for Makefile.

@lsm5
Copy link
Member Author

lsm5 commented Jan 17, 2024

Also, might wanna consider doing a 0.0.1 release or whatever to get official Fedora packaging going. Not a requirement but could be nice to have instead of just building a commit id.

albertofaria
albertofaria requested changes Jan 18, 2024
View reviewed changes
rpm/crun-vm.spec Outdated Show resolved Hide resolved
.packit.yaml Outdated Show resolved Hide resolved
rpm/crun-vm.spec Outdated Show resolved Hide resolved
@lsm5 lsm5 mentioned this pull request Jan 22, 2024
Merged
@rhatdan
Copy link
Member

rhatdan commented Jan 26, 2024

@lsm5 Needs a rebase.

@lsm5 lsm5 marked this pull request as draft January 26, 2024 11:56
@lsm5
Copy link
Member Author

lsm5 commented Jan 26, 2024

Added unit test runs on each target using TMT. lmk if it's overkill.

@lsm5 lsm5 marked this pull request as ready for review January 26, 2024 12:00
@lsm5 lsm5 changed the title Packit rpm Packit/RPM: Initial add of config and rpm spec Jan 26, 2024
@lsm5 lsm5 force-pushed the packit-rpm branch 2 times, most recently from 24a7274 to 4119c68 Compare January 26, 2024 12:36
@lsm5
Packit/RPM: Initial add of config and rpm spec
3e093f5 
Include validate and unit tests using TMT.

Also cleanup a leftover double quote in test.sh from previous commit.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 marked this pull request as draft January 26, 2024 12:51
@lsm5 lsm5 marked this pull request as ready for review January 26, 2024 12:57
@lsm5
Copy link
Member Author

lsm5 commented Jan 26, 2024

@albertofaria @rhatdan PTAL

@albertofaria
Copy link
Member

Thanks, LGTM.

@albertofaria albertofaria merged commit 0e6c844 into containers:main Jan 26, 2024
17 checks passed
@lsm5 lsm5 deleted the packit-rpm branch January 26, 2024 13:10
@lsm5
Copy link
Member Author

lsm5 commented Jan 26, 2024 •
edited
Loading

crun-vm is now installable via rhcontainerbot/podman-next copr.

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/6963842/

@rhatdan
Copy link
Member

rhatdan commented Jan 26, 2024

We are off to the races.
Now to get it into Fedora...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhatdan rhatdan rhatdan left review comments

@albertofaria albertofaria albertofaria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsm5 @rhatdan @albertofaria