Skip to content

Commit

Permalink
Merge pull request #32 from containers/docker
Browse files Browse the repository at this point in the history
Don't use `--security-opt label=disable` with Docker
  • Loading branch information
albertofaria authored Mar 15, 2024
2 parents 1bfede6 + 464252c commit dac14ae
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 14 deletions.
9 changes: 3 additions & 6 deletions docs/2-podman-docker.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
# 2. Using crun-vm as a Podman or Docker runtime

Here we overview some of the major features provided by crun-vm.

To run the examples below using Docker instead of Podman, you must additionally
pass `--security-opt label=disable` to docker-run. Other than that, and unless
otherwise stated, you can simply replace `podman` with `docker` in the commands
below.
Here we overview some of the major features provided by crun-vm. The commands
below use `podman`, but unless otherwise stated you can simply replace it with
`docker`.

## Booting VMs

Expand Down
11 changes: 3 additions & 8 deletions tests/run.rs
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,9 @@ impl Engine {

if subcommand == "run" {
match self {
Engine::Podman => {
cmd.arg(format!("--runtime={}", BINARY_PATH));
}
Engine::Docker => {
cmd.arg("--security-opt=label=disable");
cmd.arg("--runtime=crun-vm");
}
}
Engine::Podman => cmd.arg(format!("--runtime={}", BINARY_PATH)),
Engine::Docker => cmd.arg("--runtime=crun-vm"),
};
}

cmd.env("RUST_BACKTRACE", "1");
Expand Down

0 comments on commit dac14ae

Please sign in to comment.