Skip to content

Commit

Permalink
List Podman before Docker everywhere for consistency
Browse files Browse the repository at this point in the history
Signed-off-by: Alberto Faria <[email protected]>
  • Loading branch information
albertofaria committed Jul 11, 2024
1 parent fd2cb8b commit a0f1abb
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 17 deletions.
8 changes: 4 additions & 4 deletions .packit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ jobs:
- fedora-rawhide-x86_64
- fedora-40-x86_64
- fedora-39-x86_64
identifier: docker
tmt_plan: /tests/docker

- <<: *tests
identifier: podman
tmt_plan: /tests/podman

- <<: *tests
identifier: rootful-podman
tmt_plan: /tests/rootful-podman

- <<: *tests
identifier: docker
tmt_plan: /tests/docker
10 changes: 5 additions & 5 deletions plans/tests.fmf
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ execute:
tests/env.sh start
tests/env.sh run "$ENGINE" all

/docker:
summary: Run all tests under Docker
environment:
ENGINE: docker

/podman:
summary: Run all tests under Podman
environment:
Expand All @@ -59,3 +54,8 @@ execute:
summary: Run all tests under Rootful Podman
environment:
ENGINE: rootful-podman

/docker:
summary: Run all tests under Docker
environment:
ENGINE: docker
16 changes: 8 additions & 8 deletions tests/env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ COMMANDS
run <engine> <test_script>
run <engine> all
Run a test script in the test env VM under the given engine. <engine> must
be one of 'docker', 'podman', 'rootful-podman', or 'all'.
be one of 'podman', 'rootful-podman', 'docker', or 'all'.
ssh
SSH into the test env VM for debugging.
Expand Down Expand Up @@ -244,9 +244,9 @@ start)
__log_and_run podman save "$image" -o "$temp_dir/image.tar"

__exec cp /home/fedora/images/image.tar image.tar
__exec sudo docker load -i image.tar
__exec podman load -i image.tar
__exec sudo podman load -i image.tar
__exec sudo docker load -i image.tar
__exec rm image.tar

rm "$temp_dir/image.tar"
Expand Down Expand Up @@ -275,11 +275,11 @@ run)
fi

case "$2" in
docker|podman|rootful-podman)
podman|rootful-podman|docker)
engines=( "$2" )
;;
all)
engines=( docker podman rootful-podman )
engines=( podman rootful-podman docker )
;;
*)
__bad_usage
Expand All @@ -306,10 +306,6 @@ run)
__big_log 33 'Running test %s under %s...' "$( __rel "$t" )" "$engine"

case "$engine" in
docker)
engine_cmd=( sudo docker )
runtime_in_env=crun-vm
;;
podman)
engine_cmd=( podman )
runtime_in_env=/home/fedora/bin/crun-vm
Expand All @@ -318,6 +314,10 @@ run)
engine_cmd=( sudo podman )
runtime_in_env=/home/fedora/bin/crun-vm
;;
docker)
engine_cmd=( sudo docker )
runtime_in_env=crun-vm
;;
esac

# generate random label for containers created by test script
Expand Down

0 comments on commit a0f1abb

Please sign in to comment.