Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streams unit test #681

Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Refers to #293

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #681 (a4c5af4) into main (21ae04e) will increase coverage by 2.39%.
The diff coverage is 25.64%.

@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   31.19%   33.58%   +2.39%     
==========================================
  Files          12       13       +1     
  Lines         949     1039      +90     
  Branches      342      381      +39     
==========================================
+ Hits          296      349      +53     
+ Misses        441      427      -14     
- Partials      212      263      +51     

@haircommander
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6b70d8f into containers:main Sep 1, 2022
@saschagrunert saschagrunert deleted the streams-unit-test branch September 1, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants