Switch to go 1.22 #2136
Switch to go 1.22 #2136
Conversation
Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
=======================================
Coverage 37.53% 37.53%
=======================================
Files 15 15
Lines 1268 1268
Branches 414 410 -4
=======================================
Hits 476 476
+ Misses 526 525 -1
- Partials 266 267 +1 |
|
@rphillips @haircommander PTAL |
| Expect(err).NotTo(HaveOccurred()) | ||
| tr.startContainer(sut) |
There was a problem hiding this comment.
it's not clear to me why this switched
There was a problem hiding this comment.
I changed the container above to actually be valid. Fun fact is that the for loop for _, terminal := range []bool{true, false} { in go 1.21 (ginkgo related?) does not work for true, but it works in go 1.22.
|
/lgtm |
What type of PR is this?
/kind ci
What this PR does / why we need it:
Fix to the latest go version and adjust the failing test.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?