-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mkcomposefs --from-file #215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use these in other places too. Signed-off-by: Alexander Larsson <[email protected]>
This can be used to unset the current payload. Signed-off-by: Alexander Larsson <[email protected]>
If there is no payload, we should print "-" not an escaped "-". Signed-off-by: Alexander Larsson <[email protected]>
For nodes with inline data, include the content (escaped). Signed-off-by: Alexander Larsson <[email protected]>
Signed-off-by: Alexander Larsson <[email protected]>
We need to follow link chains when checking this, because none of the intermediate hardlinks are marked as in tree. Signed-off-by: Alexander Larsson <[email protected]>
@giuseppe I think containers/storage could generate this and stream it into |
This uses the format produced by composefs-info dump. Signed-off-by: Alexander Larsson <[email protected]>
…ility This is similar to the existing composefs-dump, but also tests the dump + parse dump codepaths. Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
force-pushed
the
mkcomposefs-from-dump
branch
from
October 10, 2023 16:43
0661db5
to
51c5156
Compare
Also updates the other manpages to reference the new pages as needed. Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
force-pushed
the
mkcomposefs-from-dump
branch
from
October 11, 2023 10:40
51c5156
to
bf01505
Compare
Added some documentation too.. |
giuseppe
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports creating a composefs image from a simple line-per-file format.
The format used is the same as the one that
composefs-info dump
generates, which allows conversion to from textual format. It is also a format that is very easy to produce and e.g. stream to mkcomposefs from other languages.Even though very simple to generate and parse, the format is quite compact. For example, the f36-x86_64-silverblue.json.gz file is 33M uncompressed and generates a 19M composefs image. But the dump file for it is just 16M.