Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerNetworkOptions: add driver specific options #2245

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

M1cha
Copy link
Contributor

@M1cha M1cha commented Nov 11, 2024

This allows us to pass through data to netavaark without bloating this struct. See #24523.

Required by:
containers/podman#24535
containers/netavark#1125

This allows us to pass through data to netavaark without bloating this
struct. See #24523.

Signed-off-by: Michael Zimmermann <sigmaepsilon92@gmail.com>
@mheon
Copy link
Member

mheon commented Nov 12, 2024

Sure, LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, M1cha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 305e9ce into containers:main Nov 12, 2024
16 checks passed
@M1cha M1cha deleted the per-network-opts branch November 14, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants