[skip-ci] TMT: revdep podman build test #1892

lsm5 · 2024-03-06T13:56:20Z

No description provided.

packit-as-a-service · 2024-03-06T13:56:24Z

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'common': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service · 2024-03-06T13:56:27Z

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'common': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service · 2024-03-06T13:56:30Z

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'common': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

lsm5 · 2024-03-06T15:19:22Z

@Luap99 @edsantiago @TomSweeneyRedHat PTAL. Still in draft and not ready for merge either way, but if this looks ok for starters, I'd like further comments on the test matrix to enable. Right now it's only fedora-rawhide-x86_64.

plans/podman_build_test.sh

lsm5 · 2024-03-11T14:36:08Z

@Luap99 @edsantiago @TomSweeneyRedHat @cevich PTAL

Luap99

I am not so sure how much value a build test adds, IMO build breaks are generally known by the submitter/reviewer. I guess it adds some value to prevent accidental breakages but I don't think they are very common.

I am not against doing something like this but I think we should have proper discussion first. And as a PoC could you add a "broken" commit here to see how this would look like when it fails?

plans/podman_build_test.sh

Luap99 · 2024-03-11T14:47:36Z

plans/podman_build_test.sh

+git clone https://github.com/containers/podman
+
+cd podman
+dnf -y builddep rpm/podman.spec


shouldn't this stuff be installed in the prepare step?

That would be doable if we're only running podman tests. If we also want to do buildah, skopeo and anything else, then probably best done in individual tests.

cevich · 2024-03-11T16:06:55Z

plans/main.fmf

+    summary: Build Podman
+    execute:
+        how: tmt
+        script: bash ./plans/podman_build_test.sh


As it's not directly related to building, running, or documenting podman perhaps this could live under ./contrib/tmtplans or similar?

will try with this change.

plans/podman_build_test.sh

cevich · 2024-03-11T16:08:59Z

plans/podman_build_test.sh

+
+if [ -f /etc/fedora-release ]; then
+    export TMPDIR=/var/tmp
+fi


It's unclear to me (a lay person, non-tmt expert) why this is needed. Perhaps a comment would be helpful to other non-experts?

plans/podman_build_test.sh

cevich · 2024-03-11T16:14:52Z

plans/podman_build_test.sh

+git add vendor/
+git config --global user.email "[email protected]"
+git config --global user.name "Your Name"
+git commit -am 'add vendored files'


Consider grouping all the git repository setup steps together. It will make both the logs and the script easier to read and maintain.

TomSweeneyRedHat · 2024-03-11T18:10:21Z

It would be nice to get @edsantiago 's eyeballs on this if you have the time to wait.

cevich · 2024-03-15T17:05:59Z

contrib/tmtplans/buildah_build_test.sh

@@ -0,0 +1,24 @@
+#!/usr/bin/env bash
+
+set -eox pipefail


Suggested change

set -eox pipefail

set -exo pipefail

The order here is important.

edsantiago

Quick first pass. Please also address Chris's comment.

edsantiago · 2024-03-18T18:53:27Z

contrib/tmtplans/buildah_build_test.sh

+if [ -f /etc/fedora-release ]; then
+    export TMPDIR=/var/tmp
+fi


Why the conditional? In all test environments I've seen, /var/tmp is much bigger than /tmp. It seems safest just to universally set TMPDIR=/var/tmp.

edsantiago · 2024-03-18T18:56:05Z

contrib/tmtplans/.main.fmf.swp

edsantiago · 2024-03-18T18:58:22Z

contrib/tmtplans/buildah_build_test.sh

+    export TMPDIR=/var/tmp
+fi
+
+git clone https://github.com/containers/podman


This script is named buildah_build_test but there's no buildah anything anywhere?

Now I understand the script names. Suggestion: rename both to "build_XXX" instead of XXX_build? "buildah_build_test," to me, suggests that you are testing buildah's build command.

packit-as-a-service · 2024-12-17T12:47:01Z

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

openshift-ci · 2024-12-17T12:47:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lsm5
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

packit-as-a-service · 2024-12-17T12:47:06Z

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service · 2024-12-17T12:47:10Z

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service · 2024-12-17T12:54:41Z

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service · 2024-12-17T12:54:48Z

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service · 2024-12-17T12:54:54Z

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service · 2024-12-17T12:56:52Z

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service · 2024-12-17T12:56:57Z

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service · 2024-12-17T12:57:02Z

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

rhel copr targets are often outdated causing failed builds and tests. Best to only have CentOS Stream targets upstream, so we ensure everything that enters RHEL at some point has been tested upstream. Signed-off-by: Lokesh Mandvekar <[email protected]>

Co-authored-by: Chris Evich <[email protected]> Signed-off-by: Lokesh Mandvekar <[email protected]>

lsm5 marked this pull request as draft March 6, 2024 13:56

openshift-ci bot added the do-not-merge/work-in-progress label Mar 6, 2024

lsm5 changed the title ~~TMT: revdep podman build test~~ [skip-ci] TMT: revdep podman build test Mar 6, 2024

lsm5 force-pushed the tmt-podman-revdep branch 5 times, most recently from a7c3e39 to 815cd3a Compare March 6, 2024 14:50

lsm5 commented Mar 6, 2024

View reviewed changes

plans/podman_build_test.sh Outdated Show resolved Hide resolved

lsm5 mentioned this pull request Mar 7, 2024

[skip-ci] Makefile: update rpm target containers/buildah#5388

Merged

lsm5 force-pushed the tmt-podman-revdep branch from 815cd3a to deaa412 Compare March 11, 2024 13:52

lsm5 mentioned this pull request Mar 11, 2024

Research SLO1 problems packit/packit-service#1996

Open

lsm5 marked this pull request as ready for review March 11, 2024 14:35

openshift-ci bot removed the do-not-merge/work-in-progress label Mar 11, 2024

Luap99 reviewed Mar 11, 2024

View reviewed changes

cevich reviewed Mar 11, 2024

View reviewed changes

plans/podman_build_test.sh Outdated Show resolved Hide resolved

cevich reviewed Mar 11, 2024

View reviewed changes

plans/podman_build_test.sh Outdated Show resolved Hide resolved

cevich reviewed Mar 11, 2024

View reviewed changes

lsm5 marked this pull request as draft March 12, 2024 13:24

openshift-ci bot added the do-not-merge/work-in-progress label Mar 12, 2024

lsm5 force-pushed the tmt-podman-revdep branch from deaa412 to 07b3064 Compare March 15, 2024 15:15

cevich requested changes Mar 15, 2024

View reviewed changes

edsantiago suggested changes Mar 18, 2024

View reviewed changes

lsm5 force-pushed the tmt-podman-revdep branch from 07b3064 to 792820c Compare December 17, 2024 12:46

lsm5 force-pushed the tmt-podman-revdep branch from 792820c to 5421949 Compare December 17, 2024 12:54

lsm5 force-pushed the tmt-podman-revdep branch from 5421949 to ea36990 Compare December 17, 2024 12:56

lsm5 force-pushed the tmt-podman-revdep branch 2 times, most recently from 1c8ce7d to 0b6bf43 Compare December 17, 2024 14:18

lsm5 force-pushed the tmt-podman-revdep branch from 0b6bf43 to d62b3be Compare December 18, 2024 11:14

TMT: revdep podman build test

ba5008d

Co-authored-by: Chris Evich <[email protected]> Signed-off-by: Lokesh Mandvekar <[email protected]>

lsm5 force-pushed the tmt-podman-revdep branch from d62b3be to ba5008d Compare December 18, 2024 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[skip-ci] TMT: revdep podman build test #1892

[skip-ci] TMT: revdep podman build test #1892

lsm5 commented Mar 6, 2024

packit-as-a-service bot commented Mar 6, 2024

packit-as-a-service bot commented Mar 6, 2024

packit-as-a-service bot commented Mar 6, 2024

lsm5 commented Mar 6, 2024

lsm5 commented Mar 11, 2024

Luap99 left a comment

Luap99 Mar 11, 2024

lsm5 Mar 15, 2024

cevich Mar 11, 2024

lsm5 Mar 15, 2024

cevich Mar 11, 2024

cevich Mar 11, 2024

TomSweeneyRedHat commented Mar 11, 2024

cevich Mar 15, 2024

edsantiago left a comment

edsantiago Mar 18, 2024

edsantiago Mar 18, 2024

edsantiago Mar 18, 2024

packit-as-a-service bot commented Dec 17, 2024

openshift-ci bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

[skip-ci] TMT: revdep podman build test #1892

Are you sure you want to change the base?

[skip-ci] TMT: revdep podman build test #1892

Conversation

lsm5 commented Mar 6, 2024

packit-as-a-service bot commented Mar 6, 2024

packit-as-a-service bot commented Mar 6, 2024

packit-as-a-service bot commented Mar 6, 2024

lsm5 commented Mar 6, 2024

lsm5 commented Mar 11, 2024

Luap99 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomSweeneyRedHat commented Mar 11, 2024

Choose a reason for hiding this comment

edsantiago left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

packit-as-a-service bot commented Dec 17, 2024

openshift-ci bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024

packit-as-a-service bot commented Dec 17, 2024