Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to an error message #5873

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

nalind
Copy link
Member

@nalind nalind commented Dec 12, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add words to the added context for a couple of error cases so that it's possible to tell which one of them produced the error.

How to verify it

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Signed-off-by: Nalin Dahyabhai <[email protected]>
@nalind nalind added the No New Tests Allow PR to proceed without adding regression tests label Dec 12, 2024
@openshift-ci openshift-ci bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress labels Dec 12, 2024
@nalind nalind marked this pull request as ready for review December 12, 2024 19:06
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Dec 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c7f9925 into containers:main Dec 13, 2024
32 checks passed
@nalind nalind deleted the minor-error-context branch December 13, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm No New Tests Allow PR to proceed without adding regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants