Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass cwd for hooks exec run function #4871

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'main' into pass-cwd-for-hooks-exec-run-func

f252079
Select commit
Loading
Failed to load commit list.
Open

Pass cwd for hooks exec run function #4871

Merge branch 'main' into pass-cwd-for-hooks-exec-run-func
f252079
Select commit
Loading
Failed to load commit list.
Cirrus CI / Smoke Test failed Dec 17, 2024 in 5m 14s

Task Summary

Instruction validate_test failed in 01:36

Details

✅ 00:09 clone
✅ 00:13 setup
✅ 03:12 build
❌ 01:36 validate_test

[+0000s]     SHLVL=3
[+0000s]     SHORT_APTGET=lilto apt-get -qq --yes
[+0000s]     SHORT_DNFY=lilto dnf -y
[+0000s]     SYSTEMD_EXEC_PID=1255
[+0000s]     TERM=xterm-256color
[+0000s]     USER=root
[+0000s]     WARNING_MSG_PREFIX=WARNING:
[+0000s] + make  # ./contrib/cirrus/test.sh:48 in main()
[+0004s] make -C tests/tools
[+0004s] make[1]: Entering directory '/var/tmp/go/src/github.com/containers/buildah/tests/tools'
[+0004s] make[1]: Nothing to be done for 'all'.
[+0004s] make[1]: Leaving directory '/var/tmp/go/src/github.com/containers/buildah/tests/tools'
[+0004s] make -C docs
[+0004s] make[1]: Entering directory '/var/tmp/go/src/github.com/containers/buildah/docs'
[+0004s] make[1]: Nothing to be done for 'docs'.
[+0004s] make[1]: Leaving directory '/var/tmp/go/src/github.com/containers/buildah/docs'
[+0004s] + make install.tools  # ./contrib/cirrus/test.sh:49 in main()
[+0004s] make -C tests/tools
[+0004s] make[1]: Entering directory '/var/tmp/go/src/github.com/containers/buildah/tests/tools'
[+0004s] make[1]: Nothing to be done for 'all'.
[+0004s] make[1]: Leaving directory '/var/tmp/go/src/github.com/containers/buildah/tests/tools'
[+0004s] + ooe.sh git remote add upstream https://github.com/containers/buildah.git  # ./contrib/cirrus/test.sh:53 in main()
[+0004s] + ooe.sh git remote update  # ./contrib/cirrus/test.sh:54 in main()
[+0016s] Validating a PR
[+0016s] Linting & Validating from 3cdc8b3bdebd211ac699d29342584722c215853e
[+0016s] + make lint LINTFLAGS=--timeout=20m --color=always -j1  # ./contrib/cirrus/test.sh:66 in main()
[+0016s] make -C tests/tools
[+0016s] make[1]: Entering directory '/var/tmp/go/src/github.com/containers/buildah/tests/tools'
[+0016s] make[1]: Nothing to be done for 'all'.
[+0016s] make[1]: Leaving directory '/var/tmp/go/src/github.com/containers/buildah/tests/tools'
[+0016s] ./tests/tools/build/golangci-lint run --timeout=20m --color=always -j1
[+0093s] + make validate  # ./contrib/cirrus/test.sh:67 in main()
[+0094s] make -C tests/tools
[+0094s] make[1]: Entering directory '/var/tmp/go/src/github.com/containers/buildah/tests/tools'
[+0094s] make[1]: Nothing to be done for 'all'.
[+0094s] make[1]: Leaving directory '/var/tmp/go/src/github.com/containers/buildah/tests/tools'
[+0094s] ./tests/validate/whitespace.sh
[+0094s] ./hack/xref-helpmsgs-manpages
[+0096s] ./tests/validate/pr-should-include-tests
[+0096s] pr-should-include-tests: PR does not include changes in the 'tests' directory
[+0096s] 
[+0096s] Please write a regression test for what you're fixing. Even if it
[+0096s] seems trivial or obvious, try to add a test that will prevent
[+0096s] regressions.
[+0096s] 
[+0096s] If your change is minor, feel free to piggyback on already-written
[+0096s] tests, possibly just adding a small step to a similar existing test.
[+0096s] Every second counts in CI.
[+0096s] 
[+0096s] If your commit really, truly does not need tests, you can proceed
[+0096s] by asking a repo maintainer to set the 'No New Tests' github label.
[+0096s] This will only be done when there's no reasonable alternative.
[+0096s] make: *** [Makefile:134: validate] Error 1
[12:27:20] END - [+0096s] total duration since START

Exit status: 2