Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] executor: resolve BuiltInArgs while expanding baseImage for dependencyInfo #4839

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[wip] executor: resolve BuiltInArgs while expanding baseImage for dependencyInfo #4839

wants to merge 2 commits into from

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Jun 2, 2023 •
edited
Loading

While creating a dependency info and populating baseMap, executor must consider expanding base
images with builtInArgs like TARGETARCH, TARGETOS etc so buildah can
still keep and use the stages as dependency later on.

Closes: #4820

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

executor: resolve `BultInArgs` while expanding baseImage for dependencyInfo

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 2, 2023
This was referenced Jun 2, 2023
Closed
Open
@TomSweeneyRedHat
Copy link
Member

LGTM
I dropped the Do Not Merge label on it to wait for the imagebuilder PR to merge and then vendored from there directly.

@flouthoc flouthoc requested review from nalind and rhatdan June 3, 2023 05:01
@rhatdan rhatdan changed the title executor: resolve BultInArgs while expanding baseImage for dependencyInfo [wip] executor: resolve BultInArgs while expanding baseImage for dependencyInfo Jun 5, 2023
@rhatdan rhatdan changed the title [wip] executor: resolve BultInArgs while expanding baseImage for dependencyInfo [wip] executor: resolve BuiltInArgs while expanding baseImage for dependencyInfo Jun 13, 2023
@nalind
Copy link
Member

nalind commented Jun 20, 2023

Those globals don't change their values when FROM includes a --platform= argument, so I think there are still some pieces missing here.

flouthoc added 2 commits June 21, 2023 09:15
@flouthoc
vendor: bump to flouthoc/imagebuilder
6ec93ce 
Signed-off-by: Aditya R <[email protected]>
@flouthoc
executor: resolve BultInArgs while expanding baseImage
ce3443b 
While creating a dependency map, executor must consider expanding base
images with `builtInArgs` like `TARGETARCH, TARGETOS` etc so buildah can
still keep and use the stages as dependency later on.

Closes: containers#4820

Signed-off-by: Aditya R <[email protected]>
@flouthoc flouthoc force-pushed the from-eval-default-args branch from 5fa4de4 to ce3443b Compare June 21, 2023 03:55
@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan rhatdan removed the stale-pr label Jul 24, 2023
@rhatdan
Copy link
Member

rhatdan commented Jul 24, 2023

@flouthoc any update on this one?

@flouthoc
Copy link
Collaborator Author

Just waiting for review on this one openshift/imagebuilder#258, let me bump there.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2023
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@flouthoc
Copy link
Collaborator Author

Waiting for this one openshift/imagebuilder#258

@github-actions github-actions bot removed the stale-pr label Aug 29, 2023
@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalind nalind Awaiting requested review from nalind

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Short name resolution invoked on temporary images in multi-stage build when image name composed from ARGs
5 participants
@flouthoc @TomSweeneyRedHat @nalind @rhatdan @openshift-merge-robot