Add a warning to build --secret docs
#4823
Conversation
openshift-ci
bot
added
the
kind/documentation
docs/buildah-build.1.md
Outdated
| @@ -697,6 +697,8 @@ The secret will be mounted in the container at the default location of `/run/sec | |||
| To later use the secret, use the --mount flag in a `RUN` instruction within a `Containerfile`: | |||
|
|
|||
| `RUN --mount=type=secret,id=mysecret cat /run/secrets/mysecret` | |||
|
|
|||
| Warning: Changing the contents of secret files will not trigger a rebuild of layers that use said secrets. | |||
There was a problem hiding this comment.
This should be called Note not Warning since this is expected behavior :)
There was a problem hiding this comment.
Force-pushed a fix.
|
Could you please sign the comment and add following string in commit message |
|
Done, I think. |
|
Looks like you need to cleanup dangling spaces. |
[NO NEW TESTS NEEDED] Signed-off-by: rijenkii <[email protected]>
|
A lot of stuff can go wrong while adding a single line... |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rijenkii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold cancel |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add a warning about potentially confusing behavior of
--secretflag.Not sure how to correctly word it and if it is event a good place for said warning, but oh well.
How to verify it
Which issue(s) this PR fixes:
Fixes #4822
Special notes for your reviewer:
Does this PR introduce a user-facing change?