-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user configuration to buildah container image #4674
base: main
Are you sure you want to change the base?
Add user configuration to buildah container image #4674
Conversation
The container has configuration for root, this commit adds a similar configuration for the build user. Closes: containers#4669 Signed-off-by: Norbert Lange <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nolange The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A lot of these settings are builtin to buildah and not needed. You can also copy directly your storage.conf file into its final destination, as long as you wait for the build user to be added, I don't know why you are using the /tmp directory. You are forcing the system to always use fuse-overlay, which is not always necessary for rootless containers and requires the /dev/fuse device to be added to the container. @giuseppe PTAL |
I agree we should not change the default, fuse-overlayfs must be a fallback when the native driver cannot be used |
See #4669, it fixes a real problem for me.
Cause then I would need another step to fixup owner and permissions
Its done the same way for the root user? Why is this only an argument for rootless? I would prefer to be able to use the container as-is, so if changing the build user configuration is a no-go, is adding a build_fuse user a viable path? |
I have updated the buildah image to not use fuse-overlayfs in rootful mode? Does this help fix your problem? |
Dont have the ability to check this week, but my guess is that now both root and non-root mode will not work. |
I think we need to diagnose that. |
A friendly reminder that this PR had no activity for 30 days. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The container has configuration for root,
this commit adds a similar configuration for the build user.
Closes: #4669
How to verify it
The commands displaying the configuration
should both contain:
Which issue(s) this PR fixes:
Fixes #4669
Special notes for your reviewer:
Does this PR introduce a user-facing change?