install: Add /usr/share/doc/bootc/baseimage #988
Merged
+107
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
add-install-base-configs
branch
2 times, most recently
from
0132405 to
5631254
Compare
|
Oh duh of course, can't ship empty directories in git...annoying. |
cgwalters
force-pushed
the
add-install-base-configs
branch
2 times, most recently
from
39c5625 to
eba3732
Compare
This directory will contain expected files in the base image. That said, I may change the container import path to auto-create at least the sysroot dir and symlink at some point and these can just be dropped. And for that matter after ostreedev/ostree@9a0acd7 "libostree/deploy: enable composefs by default" we can likely just drop the prepare-root bit too. But for now this is needed. Motivated by improving base image generation from https://gitlab.com/fedora/bootc/tracker/-/issues/32 Signed-off-by: Colin Walters <[email protected]>
This is mainly a sanity check for people building custom base images. But it also unit tests our own reference content. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
add-install-base-configs
branch
from
eba3732 to
7d9a160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This directory will contain expected files in the base image.
That said, I may change the container import path to auto-create
at least the sysroot dir and symlink at some point and these
can just be dropped.
And for that matter after
ostreedev/ostree@9a0acd7
"libostree/deploy: enable composefs by default"
we can likely just drop the prepare-root bit too.
But for now this is needed.
Motivated by improving base image generation from
https://gitlab.com/fedora/bootc/tracker/-/issues/32